Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style changes #26

Merged
merged 19 commits into from
Mar 22, 2020
Merged

Style changes #26

merged 19 commits into from
Mar 22, 2020

Conversation

j-f1
Copy link
Member

@j-f1 j-f1 commented Mar 22, 2020

This moves the list of posts to /archive, which is linked from the top of every post. It then redirects the homepage to the latest post. If this is undesired, I’d be happy to remove it.

@vercel
Copy link

vercel bot commented Mar 22, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/excalidraw-team/excalidraw-blog/phr1ormpf
✅ Preview: https://excalidraw-blog-git-fork-j-f1-style-changes.excalidraw-team.now.sh

@vjeux
Copy link
Contributor

vjeux commented Mar 22, 2020

image

The date looks a bit weird

@Fausto95
Copy link
Member

What's the motivation to always redirect the home page to the latest post?

@vjeux
Copy link
Contributor

vjeux commented Mar 22, 2020

I agree that the redirect feels a bit weird to me

@j-f1
Copy link
Member Author

j-f1 commented Mar 22, 2020

ok, will revert

@vjeux
Copy link
Contributor

vjeux commented Mar 22, 2020

Looks great otherwise!

vjeux
vjeux reviewed Mar 22, 2020
View reviewed changes
src/components/layout.js Outdated Show resolved Hide resolved
Fausto95
Fausto95 reviewed Mar 22, 2020
View reviewed changes
src/components/layout.js Outdated Show resolved Hide resolved
Fausto95
Fausto95 reviewed Mar 22, 2020
View reviewed changes
src/components/layout.js Outdated Show resolved Hide resolved
@lipis
Copy link
Member

lipis commented Mar 22, 2020

Looks a bit weird in my opinion.

@j-f1
Copy link
Member Author

j-f1 commented Mar 22, 2020

Which part?

@lipis
Copy link
Member

lipis commented Mar 22, 2020

The Archive!

lipis
lipis reviewed Mar 22, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
lipis
lipis reviewed Mar 22, 2020
View reviewed changes
gatsby-config.js Outdated Show resolved Hide resolved
lipis
lipis reviewed Mar 22, 2020
View reviewed changes
src/components/layout.js Outdated Show resolved Hide resolved
lipis
lipis reviewed Mar 22, 2020
View reviewed changes
.yarnrc Show resolved Hide resolved
lipis
lipis reviewed Mar 22, 2020
View reviewed changes
src/components/layout.js Outdated Show resolved Hide resolved
@j-f1 @lipis
Update src/components/layout.js
1ae0c43 
Co-Authored-By: Lipis <lipiridis@gmail.com>
@lipis
Copy link
Member

lipis commented Mar 22, 2020

Merging?

@j-f1
Copy link
Member Author

j-f1 commented Mar 22, 2020

Sure

@j-f1 j-f1 merged commit 09b7f1e into excalidraw:master Mar 22, 2020
@j-f1 j-f1 deleted the style-changes branch March 22, 2020 21:36
lipis added a commit that referenced this pull request Mar 23, 2020
@lipis
Merge branch 'master' of github.com:excalidraw/excalidraw-blog into c…
804ccc2 
…rowdin

* 'master' of github.com:excalidraw/excalidraw-blog:
  Fix Excalidraw button
  Add Excalidraw component (#27)
  Style changes (#26)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjeux vjeux vjeux left review comments

@Fausto95 Fausto95 Fausto95 left review comments

@lipis lipis lipis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@j-f1 @vjeux @Fausto95 @lipis