Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fix: Dark Mode Toggle #626

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deve-sh
Copy link

@deve-sh deve-sh commented May 20, 2023

The toggle previously took a couple of clicks on production (or a local build) to reflect the correct state (Check the attached video recording). To reproduce, open blog.excalidraw.com in an incognito window and try clicking the dark mode toggle.

Excalidraw.Blog.Dark.Mode.toggle.bug.mp4

This was due to a bug in the underlying gatsby-plugin-dark-mode plugin.

This commit works around the issue using this update.

Ref issues and code snippets:
insin/gatsby-plugin-dark-mode#13
TimTree/games-by-tim#1

The toggle previously took a couple of clicks on production to reflect the correct state.

This was due to a bug in the underlying gatsby-plugin-dark-mode plugin

This commit works around the issue.
@vercel
Copy link

vercel bot commented May 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw-blog ✅ Ready (Inspect) Visit Preview May 20, 2023 11:36am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant