Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show version in the stats dialog #2908

Merged
merged 11 commits into from Feb 4, 2021
Merged

feat: Show version in the stats dialog #2908

merged 11 commits into from Feb 4, 2021

Conversation

lipis
Copy link
Member

@lipis lipis commented Feb 3, 2021

Not sure if needed.. but sometime it's good to know when filing an issue for example.. thoughts?

@vercel
Copy link

vercel bot commented Feb 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/eg39gv2p7
✅ Preview: https://excalidraw-git-version.excalidraw.vercel.app

@lipis lipis added the discussion open for discussion; consensus not reached label Feb 3, 2021
@dwelle
Copy link
Member

dwelle commented Feb 3, 2021

I often ask for the commit hash, so it may be useful to include it even though we can get the hash from the timestamp (but only if it still shows in https://stats.excalidraw.com/).

src/utils.ts Outdated Show resolved Hide resolved
@lipis lipis requested a review from dwelle February 3, 2021 17:41
@lipis lipis removed the discussion open for discussion; consensus not reached label Feb 3, 2021
src/components/Stats.tsx Outdated Show resolved Hide resolved
* 'master' of github.com:excalidraw/excalidraw:
  fix: make scrollbars draggable when offsets are set (#2916)
  chore: Run actions on pull requests as well (#2917)
  feat: Add idle detection to collaboration feature (#2877)
  fix: pointer-events being disabled on free-draw (#2912)
  feat: don't store to LS during collab (#2909)
src/components/Stats.tsx Outdated Show resolved Hide resolved
src/locales/en.json Outdated Show resolved Hide resolved
@dwelle dwelle deleted the version branch February 4, 2021 12:47
lipis added a commit that referenced this pull request Feb 4, 2021
* 'master' of github.com:excalidraw/excalidraw: (58 commits)
  chore: Update translations from Crowdin (#2906)
  fix: toolbar unnecessarily eats too much width (#2924)
  fix: mistakenly hardcoding scale (#2925)
  fix: text editor not visible in dark mode (#2920)
  feat: support supplying custom scale when exporting canvas (#2904)
  fix: incorrect z-index of text editor (#2914)
  feat: Show version in the stats dialog (#2908)
  fix: make scrollbars draggable when offsets are set (#2916)
  chore: Run actions on pull requests as well (#2917)
  feat: Add idle detection to collaboration feature (#2877)
  fix: pointer-events being disabled on free-draw (#2912)
  feat: don't store to LS during collab (#2909)
  chore: Update translations from Crowdin (#2898)
  fix: track zenmode and grid mode usage (#2900)
  refactor: Use the latest vercel configuration instead of now (#2893)
  chore: Update translations from Crowdin (#2894)
  Update i18n.ts
  Update locales-coverage-description.js
  feat: add view mode in Excalidraw (#2840)
  chore(deps): bump @sentry/integrations from 6.0.1 to 6.0.3 (#2889)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants