fix: make scrollbars draggable when offsets are set #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/excalidraw/excalidraw/bxh2n4b1m |
|
In unrelated issue.. I think we should include pull requests here as well:
Maybe that's why actions from external branches are not running (sometimes). |
|
Thanks for the fix! |
lipis
added a commit
that referenced
this pull request
Feb 4, 2021
* 'master' of github.com:excalidraw/excalidraw: fix: make scrollbars draggable when offsets are set (#2916) chore: Run actions on pull requests as well (#2917) feat: Add idle detection to collaboration feature (#2877) fix: pointer-events being disabled on free-draw (#2912) feat: don't store to LS during collab (#2909)
lipis
added a commit
that referenced
this pull request
Feb 4, 2021
* 'master' of github.com:excalidraw/excalidraw: (58 commits) chore: Update translations from Crowdin (#2906) fix: toolbar unnecessarily eats too much width (#2924) fix: mistakenly hardcoding scale (#2925) fix: text editor not visible in dark mode (#2920) feat: support supplying custom scale when exporting canvas (#2904) fix: incorrect z-index of text editor (#2914) feat: Show version in the stats dialog (#2908) fix: make scrollbars draggable when offsets are set (#2916) chore: Run actions on pull requests as well (#2917) feat: Add idle detection to collaboration feature (#2877) fix: pointer-events being disabled on free-draw (#2912) feat: don't store to LS during collab (#2909) chore: Update translations from Crowdin (#2898) fix: track zenmode and grid mode usage (#2900) refactor: Use the latest vercel configuration instead of now (#2893) chore: Update translations from Crowdin (#2894) Update i18n.ts Update locales-coverage-description.js feat: add view mode in Excalidraw (#2840) chore(deps): bump @sentry/integrations from 6.0.1 to 6.0.3 (#2889) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf #2915 (comment)
Today when setting offsetLeft or offsetRight when using the package library, scrollbars will display, but can't be dragged. This is an attempt to fix it.