This repository has been archived by the owner on Aug 15, 2024. It is now read-only.
Added css bundling rails #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
excid3
reviewed
Oct 13, 2021
| @import "font-awesome-sprockets"; | ||
| @import "font-awesome"; | ||
| @import "bootstrap"; | ||
| @import "jumpstart/announcements"; |
There was a problem hiding this comment.
Should we still inject this into the application.bootstrap.css file?
There was a problem hiding this comment.
Ah yes. Good point.
excid3
reviewed
Oct 13, 2021
| // alert shouldn't have a bottom margin | ||
| body > .alert { | ||
| margin-bottom: 0; | ||
| } |
There was a problem hiding this comment.
I don't know that these are necessary anymore. If they are, I guess we can move them to a separate file and inject an import like the announcements.
There was a problem hiding this comment.
Seems to look fine to me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per this issue.