mark_as_unread! does not work for association collections

[elvinaspredkelis]

Hey!

This gem is a blessing and saved so much time already. I ran into this obscure use case where I'd need to mark a bunch of notifications as unread and the gem doesn't seem to support it (yet). 🤷‍♂️

Gem version: 1.2.19

Expected Behavior

Running user.notifications.mark_as_unread! should mark the notification records as not read.

Actual Behavior

Running user.notifications.mark_as_unread! throws an undefined method 'mark_as_unread!' for #<Notification::ActiveRecord_Associations_CollectionProxy:0x0000000000000> error.

Additional Information

• Running user.notifications.mark_as_read! works as one would expect.
• Documenting association methods would be a great add as well! 📚

[excid3]

I think this is a bug. The concern should define class_methods do and not module ClassMethods so that method is available.

[excid3]

Actually, seems to work without it. Added a test to confirm it was broken, but it passed.

Must be because the module name matches what Concern looks for.

[elvinaspredkelis]

Indeed. Perhaps it makes sense to add a corresponding method there to mark multiple notifications unread too?

[excid3]

Like I mentioned, it's already there and has been for a while. https://github.com/excid3/noticed/blob/master/lib/noticed/model.rb#L18-L20

Here's the test I just added to confirm it works: 8f9d070

Your model includes the Noticed::Model module?

[elvinaspredkelis]

Haha, yep, like I stated in the "Additional Information", mark_as_read! does work as expected.

The opposite function mark_as_UNread! does not exist, however.

[excid3]

Ah! I read through too quickly. 😅

I blame it being Monday. I'll get that fixed shortly.

[elvinaspredkelis]

Perfect, thank you! 👏

I suppose documenting methods for collections would be sweet as well. Might help out people who wouldn't test their luck out.

[excid3]

Released as v1.2.20

Also added to the readme with the other methods: https://github.com/excid3/noticed#-database-model

[ykamin-booth]

Hey, it seems that the mark_as_read! and mark_as_unread! methods no longer work for the association collections as of V2 with the new models. Is this intentional?

[chrisortman]

@ykamin-booth is your association empty when you call it and get the error?

Edit: Scratch that, it seems that the bang variant does not work but mark_as_unread does

[excid3]

Adding that to the UPGRADE guide.

Since they do not raise errors, we removed the ! to be consistent with Rails save and save!