DOC: Add guidance for configuring gh-pages #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds instructions to configure GitHub Pages to correctly find and deploy the built files.
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
choldgraf
reviewed
Nov 15, 2022
choldgraf
approved these changes
Nov 15, 2022
choldgraf
changed the title
|
Congrats on your first merged pull request in this project! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to adds instructions for configuring GitHub Pages to correctly find and deploy the built files. It is not fully obvious what happens to the built files and how that should be reflected in the settings, so I think it's worth mentioning this somewhere on this page.
If you agree it's worth adding, please let me know how it can be more clear and I'll update ASAP.