Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: adding python 3.10 to the testing matrix and tox #1987

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

bsipocz
Copy link
Contributor

@bsipocz bsipocz commented Apr 1, 2023

This should close #1504

Things I wonder about:

  • why isn't tox utilized in the CI config?
  • should also try adding python 3.11, I'll do that once 3.10 is all good to go.

@welcome
Copy link

welcome bot commented Apr 1, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks! A few responses:

re: py 3.11

Go for it!

re: tox in ghactions

I'd be +1 on this if you know of a good way to re-use the cache for the environment etc. Happy to review a PR that implements.

@choldgraf
Copy link
Collaborator

I fixed up the broken CI in another PR to make sure we can test this one properly, looks like it is in good shape! Let me know if you'd like to tackle 3.11 and/or tox-in-actions improvements here or in follow-ups

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (932b572) 91.48% compared to head (0506249) 91.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1987   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files           7        7           
  Lines         693      693           
=======================================
  Hits          634      634           
  Misses         59       59           
Flag Coverage Δ
pytests 91.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bsipocz
Copy link
Contributor Author

bsipocz commented Apr 14, 2023

@choldgraf - I would rather do them as follow-ups, no need to bog down something that works with unpredictable time schedules or unforeseen potential issues with the new versions.

@bsipocz
Copy link
Contributor Author

bsipocz commented Apr 14, 2023

I'd be +1 on this if you know of a good way to re-use the cache for the environment etc. Happy to review a PR that implements.

I don't know how to do the cache yet, but is that really that critical? This one doesn't seem to be a super busy repo where optimizing CI that way could save a lot (but I'm adding it to the list to look into as then I could reuse the solutions elsewhere where it may have a bigger effect).

@choldgraf
Copy link
Collaborator

definitely not a deal-breaker, just a suggestion! OK let's merge this one. Thanks for the improvement!

@choldgraf choldgraf merged commit 97d8c32 into jupyter-book:master Apr 14, 2023
@welcome
Copy link

welcome bot commented Apr 14, 2023

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@agoose77 agoose77 changed the title CI: adding python 3.10 to the testing matrix and tox MAINT: adding python 3.10 to the testing matrix and tox Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python 3.10
2 participants