-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: adding python 3.10 to the testing matrix and tox #1987
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks! A few responses:
re: py 3.11
Go for it!
re: tox in ghactions
I'd be +1 on this if you know of a good way to re-use the cache for the environment etc. Happy to review a PR that implements.
I fixed up the broken CI in another PR to make sure we can test this one properly, looks like it is in good shape! Let me know if you'd like to tackle 3.11 and/or tox-in-actions improvements here or in follow-ups |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1987 +/- ##
=======================================
Coverage 91.48% 91.48%
=======================================
Files 7 7
Lines 693 693
=======================================
Hits 634 634
Misses 59 59
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@choldgraf - I would rather do them as follow-ups, no need to bog down something that works with unpredictable time schedules or unforeseen potential issues with the new versions. |
I don't know how to do the cache yet, but is that really that critical? This one doesn't seem to be a super busy repo where optimizing CI that way could save a lot (but I'm adding it to the list to look into as then I could reuse the solutions elsewhere where it may have a bigger effect). |
definitely not a deal-breaker, just a suggestion! OK let's merge this one. Thanks for the improvement! |
This should close #1504
Things I wonder about: