-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Practice around supported Python and Sphinx versions #513
Comments
If you don't test against 3.7, then you are not supporting it: it'll be most likely that new code changes would break support for the oldest version of python than any other (using newer syntax features that are not supported or require a back port package). |
I guess the main concern is having tons of jobs in our CI/CD as new versions are released. Questions
|
(I also don't feel that strongly that we need to only test 3 python versions, if others don't think it's a big deal...it just seemed like a reasonable number to balance n_jobs and coverage) |
Another thing I would suggest is that the (documented) aim should be for the the support to come within maybe 6 months of the release of new versions, e.g. as soon as sphinx v4 came out there were people asking for its support, which is understandable, but obviously depending on the number of breaking changes it's unlikely going to be feasible to roll out support for all JB dependencies within days |
I tend to agree we should test against all supported @choldgraf perhaps we should force the tests to pass for |
Description
Two of the big dependencies for our stack are Python and Sphinx. We should decide on a policy to follow for "officially" supporting Python and Sphinx versions in our test suites.
Python
In #306 @chrisjsewell suggested that we use the Python end-of-life dates to decide which versions of Python to support.
I suggest that we do the following:
Sphinx
IN #306 we had some discussion and this seemed to land on officially supporting the last 2 major versions of Sphinx.
Tasks
The text was updated successfully, but these errors were encountered: