fix/server blatting #685
Merged
fix/server blatting #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A better check on the user server should include pinging the |
|
stevejpurves
added a commit
that referenced
this pull request
Sep 6, 2023
* 🔧 use correct binder repo url * 🫴🏼 hooks no longer throw on undefined contexts * 📕 changeset * allow custom repoproviderspecs to be added to react server provider * 🥁don't provide np-ops * 🙅🏽 throw exception for malformed RepoProviderSpec * fix/server blatting (#685) * 📡 add check call for user server * 👮🏻 prevent reconnect for existing server * 📕 changeset
stevejpurves
added a commit
that referenced
this pull request
Sep 6, 2023
* add binder urls * server holds url set for binder * user server url has meaning outside of binder * fix/tolerant providers (#683) * 🔧 use correct binder repo url * 🫴🏼 hooks no longer throw on undefined contexts * 📕 changeset * allow custom repoproviderspecs to be added to react server provider * 🥁don't provide np-ops * 🙅🏽 throw exception for malformed RepoProviderSpec * fix/server blatting (#685) * 📡 add check call for user server * 👮🏻 prevent reconnect for existing server * 📕 changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ThebeServerProvidercould replace active servers during navigaion easily, these changes protect against that by checking to see if the server is already "ready" and has a user server url.This complements well the existing
disconnectfunctionality.