extend binder url handling #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
* 🔧 use correct binder repo url * 🫴🏼 hooks no longer throw on undefined contexts * 📕 changeset * allow custom repoproviderspecs to be added to react server provider * 🥁don't provide np-ops * 🙅🏽 throw exception for malformed RepoProviderSpec * fix/server blatting (#685) * 📡 add check call for user server * 👮🏻 prevent reconnect for existing server * 📕 changeset
This was referenced Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR is to make a ThebeServer the course of truth for binder links, if the server connection was established via binder.
The ThebeServer also provides the user server url as a string for convenience for non-custom connection methods.