new(filtering): whitelist current executable #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banditopazzo
approved these changes
Jan 18, 2023
Fix #128 by whitelisting the current process path instead of the current PID. This allows to ignore the client CLI executable. Failing to ignore it would lead to loops of events, see issue #128 for more details. Add option `process-monitor.ignore_self`, which can be used to disable this default behaviour.
MatteoNardi
force-pushed
the
128-pulsar-monitor-all-generates-loop-of-events
branch
from
07816ec
to
d25a9ab
Compare
MatteoNardi
deleted the
128-pulsar-monitor-all-generates-loop-of-events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #128 by whitelisting the current process path instead of the current PID. This allows to ignore the client CLI executable. Failing to ignore it would lead to loops of events, see issue #128 for more details.
Add option
process-monitor.ignore_self, which can be used to disable this default behaviour.I have
cargo fmt;cargo clippy;cargo testand all tests pass;