Standardize test naming across exercises #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjwarner-bp
reviewed
Jan 4, 2018
There was a problem hiding this comment.
I think the reason this happens is because our exercise readme insert chooses to say bats whatever_test.sh.
If we are going to change this, it should probably be changed in the exercise readme insert.
Any suggestions?
|
I am confused as to why there are two PRs (this and #130)? They look to contain some of the same changes, and generally look related. |
|
You have an answer in #130 |
kotp
approved these changes
Jan 6, 2018
|
I forgot to squash my commits, is there any way to squash them now when the PR is merged without any side effects? |
Yes, you can do so, but it isn't worth the potential for irritation. |
This was referenced Jan 7, 2018
Closed
|
I'll leave it as it is then, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's better to integrate this after #130