implement exercise nucleotide-count #80
Conversation
|
This looks good to me. I did notice that there are no tests that are skipped. @exercism/bash are we skipping all but the first test by default to reduce the noise when solving these, until we pass each test? |
|
@kotp It doesn't look like any of the other exercises do this, but it might be a good policy to adapt. |
|
For the Ruby and Delphi tracks we skip all but the first test. The very first exercise, I think for both tracks, have comments with an explanation of what to do to unskip them, and perhaps also duplicated in the Readme. This could definitely be a different pull request, that could touch the existing exercises. |
|
Yeah, that's what we do in the java track too. I'll open another issue for that and start working on it. In the meantime, should we decided on core exercise/unlocked by? It looks like right now all the exercises depend on panagram. Should I do the same here? |
|
Leap, Bob, and a couple others are not unlocked by Pangram. But this being unlocked by Pangram seems to be OK, at least at first thought. |
|
|
||
| Run the tests with: | ||
|
|
||
| bats whatever_test.sh |
There was a problem hiding this comment.
replace with bats nucleotide_count_test.sh ?
There was a problem hiding this comment.
The readme file for every exercise is generated by configlet. This is the track-specific insert that we have for this track. EXERCISE_README_INSERT
|
|
||
| for i in $(seq 1 ${#input}); do | ||
| char=${input:i-1:1} | ||
| if [ $char = "A" ]; then |
There was a problem hiding this comment.
shellcheck says:
"Double quote to prevent globbing and word splitting."
--> replace $char by "$char"
Also, to have a better standard in the example, replace
See this for ex.
So $char -> "${char}"
|
Thanks for the PR! LGTM |
I did my best to choose topics and a difficulty for the exercise. The only last two things are should it be a core exercise? If not, what should it be unlocked by?