-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-achitect grade-school #683
Conversation
566a7c9
to
578490c
Compare
Example implementation here: exercism/c#683 Fixes #1824
56f742c
to
d674ec0
Compare
I don't like relying on the unit under test for the |
Perhaps it would be better to have an init function that is called in |
/format |
I like extracting the state into |
Whoops. This is complete waffle. 😆 CI link check is failing for a link that recently started to time out sporadically - I'll change that link on a separate PR. |
I also missed the obvious solution. It's so obvious in retrospect! |
The problem specification for grade-school has some issues.
Trying to re-architect the
grade-school
tests here so as to build a new problem specification based on and with referenced to a working example.The implementation is relatively unchanged.
gcov
tells me the new tests exercise all lines of, so I start from here and see if a problem specification that reflects these new tests is acceptable.Having said that, there are some TODOs currently left in these tests. I plan to resolve these in later commits, so that planned additional changes are easier to follow.