Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grade school: new test raises a question #1824

Closed
glennj opened this issue Jul 23, 2021 · 3 comments · Fixed by #1837
Closed

Grade school: new test raises a question #1824

glennj opened this issue Jul 23, 2021 · 3 comments · Fixed by #1837

Comments

@glennj
Copy link
Contributor

glennj commented Jul 23, 2021

Regarding PR #1819

        {
          "uuid": "6a03b61e-1211-4783-a3cc-fc7f773fba3f",
          "reimplements": "c125dab7-2a53-492f-a99a-56ad511940d8",
          "comments": [
            "Reimplemented to be logically consistent"
          ],
          "description": "A student cannot be added to more than one grade in the sorted roster",
          "property": "roster",
          "input": {
            "students": [["Aimee", 2], ["Aimee", 1]]
          },
          "expected": ["Aimee"]
        },

All well and good, but what grade is Aimee in?

  1. grade 2 because that's what came first, or
  2. grade 1 because that's what came last?

I think we're missing the property:grade test for this scenario.

@glennj
Copy link
Contributor Author

glennj commented Jul 23, 2021

IMO either interpretation is valid, but we need to make a decision. Maybe a vote by reaction:

  1. ❤️ for grade 1
  2. 👀 for grade 2

@wolf99
Copy link
Contributor

wolf99 commented Jul 24, 2021

Intention after the mentioned PR was to rewrite the spec completely such that it covers the operation of adding students, as this clears up this and a lot of other issues.

@glennj
Copy link
Contributor Author

glennj commented Jul 24, 2021

I see. I'll wait patiently then.

(taps foot, checks watch)

wolf99 added a commit that referenced this issue Sep 13, 2021
Example implementation here: exercism/c#683

Fixes #1824
wolf99 added a commit that referenced this issue Oct 11, 2021
Fixes #1824

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
wolf99 added a commit that referenced this issue Oct 11, 2021
Fixes #1824

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
wolf99 added a commit that referenced this issue Oct 12, 2021
Fixes #1824

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
wolf99 added a commit that referenced this issue Oct 18, 2021
Fixes #1824

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants