Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make zsh completion work on $fpath. #806

Merged
merged 3 commits into from
Feb 26, 2019
Merged

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Feb 10, 2019

This allows the file to be placed, e.g., in a system-wide site-functions directory and just work automatically.

Now, I don't use zsh personally, but I tried to copy what the fd, ripgrep, and restic packages do, and also the beginning of these zsh-completion instructions. I tested it out both system-wide, and user-only (with the instructions here), and it works. I don't know if the oh-my-zsh instructions are correct though.

This allows the file to be placed, e.g., in a system-wide
`site-functions` directory and just work automatically.
shell/exercism_completion.zsh Outdated Show resolved Hide resolved
shell/README.md Outdated Show resolved Hide resolved
@QuLogic
Copy link
Contributor Author

QuLogic commented Feb 25, 2019

@NobbZ OK, hopefully that takes care of the comments you made.

Copy link
Member

@kytrinyx kytrinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NobbZ It looks like your comments were addressed. I'm going to merge this, and if you have further suggestions we can address it in a future PR.

@QuLogic Thank you for taking the time to work through this one! 🍰

@kytrinyx kytrinyx merged commit 4924d44 into exercism:master Feb 26, 2019
@QuLogic QuLogic deleted the zsh-fpath branch February 27, 2019 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants