Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change design of meetup problem #21

Closed
kytrinyx opened this issue Aug 31, 2014 · 3 comments
Closed

Change design of meetup problem #21

kytrinyx opened this issue Aug 31, 2014 · 3 comments

Comments

@kytrinyx
Copy link
Member

@pminten brought up a very good point about the API of meetup being
pretty terrible (See exercism/exercism#950).

If the meetup problem has not already been fixed in this track, we should
improve the test suite and example code to give the API a better design.

mathias added a commit to mathias/xclojure that referenced this issue Oct 21, 2014
- Per exercism#21 we don't want to be doing metaprogramming at this point (Or in the example code's case, dynamically creating functions)
@mathias
Copy link
Contributor

mathias commented Oct 21, 2014

I have the tests converted to the new API in mathias@e9c0cfc but still need to redo the example. (Hooray for vim macros when I went to rewrite the tests. Saved me a ton of time!)

mathias added a commit to mathias/xclojure that referenced this issue Oct 21, 2014
- Per exercism#21 we don't want to be doing metaprogramming at this point (Or in the example code's case, dynamically creating functions)
@kytrinyx
Copy link
Member Author

Sweet, I look forward to seeing it.

@mathias
Copy link
Contributor

mathias commented Oct 23, 2014

Question for the others watching exercism/xclojure: At this point in the exercises, how do we want the simplified meetup example to work? The Java example uses a switch statement, which I could replicate with a cond, but dispatching based on the "schedule" argument could also be done with an inner function using Protocols or Multimethods. I'm just not sure if protocols have been introduced at this point in the exercises for Clojure.

Thoughts? Suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants