Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary patch to get CI working again #475

Merged
merged 3 commits into from
Apr 28, 2022
Merged

Temporary patch to get CI working again #475

merged 3 commits into from
Apr 28, 2022

Conversation

bobbicodes
Copy link
Member

@bobbicodes bobbicodes commented Apr 27, 2022 •
edited
Loading

Upgraded the babashka Docker action to the one currently maintained by the community.

@bobbicodes bobbicodes marked this pull request as draft April 27, 2022 19:25
@bobbicodes bobbicodes mentioned this pull request Apr 27, 2022
Closed
@bobbicodes bobbicodes changed the title Use turtlequeue/setup-babashka Docker action Debugging CI Action Apr 27, 2022
@bobbicodes
Copy link
Member Author

bobbicodes commented Apr 28, 2022 •
edited
Loading

The libs.jar file was not being added to the classpath in CI because it's in a different location at that point.
(Took me 2 full days to figure that out!)
Temporarily using a local copy of the test-runner script instead of cloning the actual test-runner repo.

This is not ideal because it's no longer a real integration test. I'll want to fix this at some point but right now my brain is tired and I'm just happy to see everything green again.

@bobbicodes bobbicodes changed the title Debugging CI Action Temporary patch to get CI working again Apr 28, 2022
@bobbicodes bobbicodes marked this pull request as ready for review April 28, 2022 01:53
@bobbicodes bobbicodes requested a review from a team April 28, 2022 02:03
SleeplessByte
SleeplessByte approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably fine?

@bobbicodes bobbicodes merged commit 1cd3f86 into main Apr 28, 2022
@bobbicodes bobbicodes deleted the BTowersCoding-patch-2 branch April 28, 2022 02:08
@bobbicodes bobbicodes mentioned this pull request Sep 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleeplessByte SleeplessByte SleeplessByte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobbicodes @SleeplessByte