build: bump Nim from 1.4.4 to 1.4.6 #282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small patch release.
See:
In case anybody was wondering: bumping the version in
configlet.nimble
isn't necessary, but I do it deliberately. Our codebase will likely compile with some older version, but I don't want to keep track of the lowest supported Nim version (or add earlier Nim versions to CI).People use
configlet
as a binary, not a library, so we're just forcingconfiglet
developers to have the latest stable (or a recentdevel
) version of Nim installed. That's a little annoying, but it does eliminate an entire class of issues. And it's more user-friendly than seeing errors due to old/untested Nim versions.