Included posix_time header in test. Changed Example accordingly (#149). #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcuru
reviewed
Sep 30, 2017
| @@ -1,7 +1,9 @@ | |||
| #if !defined(GIGASECOND_H) | |||
| #define GIGASECOND_H | |||
|
|
|||
| #include <boost/date_time/posix_time/posix_time.hpp> | |||
There was a problem hiding this comment.
We really shouldn't bother removing this here. It doesn't save anything since it always must be included to use this header anyways.
Yes it might be against some companies guidelines, but we're going for simplicity here instead of strictly following some definition of best practice. These tests just aren't going to do much to help teach best practices on a large Cpp codebase.
|
Thanks for this. If you add "Closes #149" to the description (first comment?) or in a commit message it will auto close the issue once this is merged. See https://help.github.com/articles/closing-issues-using-keywords/ I'm not sure if it works for a comment like this. |
This was referenced Aug 24, 2018
|
Closing in favor of #201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just wanted to propose a solution for the case that you might consider the issue I opened to be valid. I hope this was somehow helpful to you.
Cheers,
Lukas