tests: update crypto-square exercise #827
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
| { | ||
| REQUIRE("tsf hiu isn" == crypto_square::cipher("This is fun!").normalized_cipher_text()); | ||
| TEST_CASE( | ||
| "8 character plaintext results in 3 chunks, the last one with a trailing " |
There was a problem hiding this comment.
Currently, line breaks in the "name" of the exercise will break the test runner, can you keep them on one line until I fix this behavior?
There was a problem hiding this comment.
Alright, put it on one line.
In that context I was wondering again about formatting here and also other files. Turns out the formatting checks in CI are broken. Details here: #834
ahans
force-pushed
the
feature/sync-crypto-square
branch
from
29474e4
to
5f06423
Compare
The original tests expected that the implementation also exposes intermediate steps, such as the normalized plaintext. I think this unnecessarily restricts the implementation and is also not reflected in the canonical data. So now I changed all tests to exactly correspond to the canonical data. Let me know if that's not what I should have done. I can also just add the one extra test case. But adding the test UUIDs would be a bit hard then ...