Generate exercises using x-common

[tejasbubane]

Looks like this track is about to be launched soon (with almost 9 exercises now).

I think we should generate all exercises from x-common. I see a lot of PRs in x-ruby changing the static exercise files to dynamically generated ones. Using it from the start in a new repo like this is better instead of converting them later.

Not sure if this should be enforced on all PRs. What are your views regarding this?

[elorest]

I wrote this last night to create a specs from x-common.

@cases = [cases, from, x-common]
File.open("spec.cr", "w+") do |f|
  @cases.each do |c|
  f.puts %/it "#{c[:description]}" do/
  f.puts %/  Series.new("#{c[:digits]}").largest_product(#{c[:span]}).should eq #{c[:expected]}/
  f.puts "end"
  end
end

[mhelmetag]

@elorest , Nice! Something like this could probably be expanded to make specs for every exercise's json file in the x-common repo.

[elorest]

My thoughts as well. I'll work on that when I have a chance. I just put in
2 weeks at my work so I'm swamped trying to finish up a million things so
I don't leave them in a pinch.

On Jul 21, 2016 9:48 PM, "Max Helmetag" notifications@github.com wrote:

@elorest https://github.com/elorest , something like this could
probably be expanded to make specs for every exercise's json file in the
x-common repo.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#20 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHmpHBp1W7JA9KM5RxPpJRoDyeusN1Rks5qYD2OgaJpZM4JRfqe
.

[tejasbubane]

Looks like xruby also uses some kind of common generator. We can follow the same architecture as described in xruby's generated section.

[mhelmetag]

I feel like the test metadata (json files) in x-common need to be standardized with description, input and expected. Currently there are some files that are kind of all over the place... but I am making some progress with a generator that pulls directly from the github repo online.

[kytrinyx]

Yeah, we haven't really figured out what to standardize on, and any thoughts about how to do that are very welcome. If you have thoughts about it, would you mind opening something in the x-common repository?

I am making some progress with a generator that pulls directly from the github repo online.

Sweet! There's some talk about improving the Ruby generators, too. exercism/ruby#396 (comment) If several people are thinking about this at once, it could be worth starting a discussion in the github.com/exercism/discussions/issues repo.

[mhelmetag]

@bmulvihill has ported over a spec generator similar to the one in xruby 🎊 so now we can make test case templates like they do! One thing I will work on adding is getting the json from x-common over http or local file system (so that there's a choice).