Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual test for automerge of dependencies #984

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

robkeim
Copy link
Contributor

@robkeim robkeim commented Feb 27, 2019

If this works then I'll update the script and add this to all of the projects. I just didn't want to create another wave of spam if something isn't right with this configuration.

automerged_updates:
- match:
dependency_type: "all"
update_type: "semver:minor"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also wait for the CI to become green?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

https://dependabot.com/docs/config-file/#automerged_updates

For all of the options below Dependabot will wait until all your status checks pass before merging.

@ErikSchierboom
Copy link
Member

@robkeim I'm really hoping work will be done on this issue.

@robkeim
Copy link
Contributor Author

robkeim commented Feb 27, 2019

Yeah that would definitely be nice, because each time xunit gets updated we're going to get ~100 PRs generated which can create a lot of noise. I have to admit I've never used this on a project with so many csproj's before :)

@ErikSchierboom ErikSchierboom merged commit 00feef6 into exercism:master Feb 27, 2019
@ErikSchierboom
Copy link
Member

Right, merged! Let's see what happens :)

@ErikSchierboom
Copy link
Member

This is a rather unusual project with some many individual project files. So it would be a most welcome feature.

@greysteil
Copy link

Hey, if you update the config file to have a single update config, pointing at the /exercises directory, then Dependabot will pick up the Exercises.sln file there and create PRs that group together updating all of the individual projects, rather than individual PRs for each project.

(We need to make it clearer that that's the case, particularly for folks using config files.)

@ErikSchierboom
Copy link
Member

@greysteil That's a great hint! @robkeim, did you see this?

@ErikSchierboom
Copy link
Member

@robkeim When we have this work properly, we can then try and do the same for F#, which should then result in far less PR's :)

@ErikSchierboom
Copy link
Member

@greysteil Would the config look something like this then:

version: 1

update_configs:
    - package_manager: "dotnet:nuget"
      directory: "/exercises"
      update_schedule: "live"
      automerged_updates:
        - match:
            dependency_type: "all"
            update_type: "semver:minor"

    - package_manager: "dotnet:nuget"
      directory: "/generators"
      update_schedule: "live"
      automerged_updates:
        - match:
            dependency_type: "all"
            update_type: "semver:minor"

@greysteil
Copy link

Yes, that should work!

@robkeim
Copy link
Contributor Author

robkeim commented Feb 27, 2019

Thanks @greysteil for the tip!

@robkeim robkeim deleted the dependabot-auto-merge branch November 8, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants