Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Re-enable link checker #420

Closed
devkabiir opened this issue Oct 30, 2022 · 11 comments
Closed

[CI] Re-enable link checker #420

devkabiir opened this issue Oct 30, 2022 · 11 comments

Comments

@devkabiir
Copy link
Contributor

As part of #398, the link checker workflow was disabled for exercises.

@Stargator may have more insights as to why that change was made & whether it should be fixed or kept as is.

This issue tracks that change.

@kytrinyx
Copy link
Member

We could try enabling it in a PR to see what breaks.

@Stargator
Copy link
Contributor

The link checker or Links workflow was disabled due to a bug that caused it not to handle mailto links properly.

So it would fail every time if a file that contained a mailto was modified.

I checked the repo for the underlying library and no new releases since 0.10.1, which is what we currently use.

@kytrinyx
Copy link
Member

Got it! Thanks for checking.

@kytrinyx
Copy link
Member

kytrinyx commented Nov 4, 2022

We're looking to add a link checker to problem-specifications as well. This is the PR: exercism/problem-specifications#2145

Once that one is resolved we'll likely have a way forward in this repository as well.

@Stargator
Copy link
Contributor

lynchee is pretty useful. But I'm not tied to it. Feel free to do a manual run of our Link workflow to ensure it still fails at mailto link, which lynchee should support.

@Stargator
Copy link
Contributor

@kytrinyx Since the lychee action was just updated, I re-ran the workflow and it's still failing for mailto.

@Stargator
Copy link
Contributor

This is the related issue at lychee

@kytrinyx
Copy link
Member

kytrinyx commented Nov 4, 2022

Thank you for checking, @Stargator.

@mre
Copy link

mre commented Nov 5, 2022

Fix is here: lycheeverse/lychee#809.
Would be thankful if you could take a look and maybe test it locally to see if this resolves the problem.

@mre
Copy link

mre commented Nov 9, 2022

New version of lychee-action with the fix is out.

@Stargator
Copy link
Contributor

Thanks, @mre!

I re-enabled the workflow, it's passing. So I'm leaving in en-enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants