-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update urls from 'http' to 'https' #368
Conversation
@lakshya8066 thanks. I just meant to do the fixes in the same PR. But this works too. |
@@ -19,5 +19,5 @@ | |||
] | |||
}, | |||
"source": "JavaRanch Cattle Drive, exercise 3", | |||
"source_url": "http://www.javaranch.com/leap.jsp" | |||
"source_url": "https://www.javaranch.com/leap.jsp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It redirects to this page: https://coderanch.com/t/718816/Leap
. So might as well switch them
Just went through all the links and tagged the ones that do not work with https |
Hey there; lychee author here. Thanks for using the tool. Just dropping in because I noticed that the PR comments mention a couple of links that don't support HTTPS just yet. args: --verbose --no-progress **/*.md **/*.html |
@mre Thanks. We did try one run-through with that (in the PR that has the respective action), but we got an error that said --require-https was not recognized or something along those lines. Anyway, the point is moot since this PR has revealed some URLs that do not work as https because https is not supported by those websites. So we can't require https until those websites support https. But thanks for coming over and checking us out! |
The latest version of the lychee action has this flag now. |
@mre Thanks for the clarification. |
@Stargator I have reverted those websites and cross-checked them as well, they are working fine. |
@lakshya8066 Everything is good to go, this branch just needs to be updated with the changes from the |
Thanks @Stargator, I can take this opportunity to learn about rebasing while applying it... |
Signed-off-by: Lakshya Gupta <lakshya.gupta.1999@gmail.com>
Signed-off-by: Lakshya Gupta <lakshya.gupta.1999@gmail.com>
@Stargator is it correct? |
The ready to rebase commit needs to switch dartlang.org for dart.dev |
@lakshya8066 Thanks for your MONTH LONG work! 🥳 I really, really appreciate that. |
Thanks @Stargator, it was a pretty fun ride!😀 |
This pull request replaces all 'http' with 'https' in links.
Fixes partially #360