Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update urls from 'http' to 'https' #368

Merged
merged 8 commits into from
Dec 4, 2021
Merged

Update urls from 'http' to 'https' #368

merged 8 commits into from
Dec 4, 2021

Conversation

lakshya8066
Copy link
Contributor

This pull request replaces all 'http' with 'https' in links.
Fixes partially #360

@lakshya8066 lakshya8066 changed the title Update urls to 'https' Update urls from 'http' to 'https' Nov 18, 2021
@Stargator
Copy link
Contributor

@lakshya8066 thanks. I just meant to do the fixes in the same PR. But this works too.

docs/TESTS.md Outdated Show resolved Hide resolved
exercises/practice/allergies/.meta/config.json Outdated Show resolved Hide resolved
@@ -19,5 +19,5 @@
]
},
"source": "JavaRanch Cattle Drive, exercise 3",
"source_url": "http://www.javaranch.com/leap.jsp"
"source_url": "https://www.javaranch.com/leap.jsp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It redirects to this page: https://coderanch.com/t/718816/Leap. So might as well switch them

@Stargator
Copy link
Contributor

Just went through all the links and tagged the ones that do not work with https

@mre
Copy link

mre commented Nov 22, 2021

Hey there; lychee author here. Thanks for using the tool.

Just dropping in because I noticed that the PR comments mention a couple of links that don't support HTTPS just yet.
There is a --require-https in lychee which treats HTTP links as errors if an HTTPS link exists.
Might be helpful to add that to your lychee action over at #360:

args: --verbose --no-progress **/*.md **/*.html

@Stargator
Copy link
Contributor

@mre Thanks. We did try one run-through with that (in the PR that has the respective action), but we got an error that said --require-https was not recognized or something along those lines.

Anyway, the point is moot since this PR has revealed some URLs that do not work as https because https is not supported by those websites. So we can't require https until those websites support https.

But thanks for coming over and checking us out!

@mre
Copy link

mre commented Nov 23, 2021

The latest version of the lychee action has this flag now.
Also require-https only throws an error when an https link is actually available but an http link was used. 😉

@Stargator
Copy link
Contributor

@mre Thanks for the clarification.

@lakshya8066
Copy link
Contributor Author

@Stargator I have reverted those websites and cross-checked them as well, they are working fine.

@Stargator
Copy link
Contributor

@lakshya8066 Everything is good to go, this branch just needs to be updated with the changes from the main branch. Are you comfortable doing a rebase? If not, I can do it.

@lakshya8066
Copy link
Contributor Author

Thanks @Stargator, I can take this opportunity to learn about rebasing while applying it...

lakshya8066 and others added 7 commits November 30, 2021 23:35
Signed-off-by: Lakshya Gupta <lakshya.gupta.1999@gmail.com>
Signed-off-by: Lakshya Gupta <lakshya.gupta.1999@gmail.com>
@lakshya8066
Copy link
Contributor Author

@Stargator is it correct?

@Stargator
Copy link
Contributor

The ready to rebase commit needs to switch dartlang.org for dart.dev

@Stargator Stargator merged commit 9425cb7 into exercism:main Dec 4, 2021
@Stargator
Copy link
Contributor

@lakshya8066 Thanks for your MONTH LONG work! 🥳 I really, really appreciate that.

@lakshya8066
Copy link
Contributor Author

Thanks @Stargator, it was a pretty fun ride!😀

@lakshya8066 lakshya8066 deleted the update-urls branch December 4, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants