Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test.yml: Restrict action to only when dart related files change #372

Merged
merged 3 commits into from
Jan 3, 2022
Merged

test.yml: Restrict action to only when dart related files change #372

merged 3 commits into from
Jan 3, 2022

Conversation

Stargator
Copy link
Contributor

No description provided.

@Stargator Stargator self-assigned this Dec 5, 2021
@Stargator Stargator requested a review from a team December 5, 2021 17:30
@Stargator
Copy link
Contributor Author

@devkabiir or @ErikSchierboom Could you please review this?

devkabiir
devkabiir approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@devkabiir devkabiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we happen to end up using any kind of fixtures in tests (e.g. from a json file) that dont match these glob patterns. The PR that updates the fixtures would silently pass, even if they dont pass the tests anymore.

.github/workflows/links.yml Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
Stargator
Stargator commented Jan 3, 2022
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
@Stargator Stargator merged commit 65084f7 into exercism:main Jan 3, 2022
@Stargator Stargator deleted the limit-tests-on-dart-changes branch January 3, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devkabiir devkabiir devkabiir approved these changes

Assignees

@Stargator Stargator

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stargator @devkabiir