Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate accumulate #1032

Merged
merged 1 commit into from
Jan 15, 2022
Merged

Deprecate accumulate #1032

merged 1 commit into from
Jan 15, 2022

Conversation

angelikatyborska
Copy link
Contributor

@angelikatyborska angelikatyborska added the x:size/small Small amount of work label Jan 14, 2022
@github-actions
Copy link
Contributor

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps
    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)

Automated comment created by PR Commenter 🤖.

Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly happens now? It won't appear on the tree since it doesn't;t practice anything, but it will still be in the full list?

@angelikatyborska
Copy link
Contributor Author

It will disappear completely from anywhere except for students that already started it, they will see it on the full list. E.g. both "binary" and "hexadecimal" are deprecated. I can find "binary" on my exercise list because I solved it, but not "hexadecimal".

@angelikatyborska angelikatyborska merged commit 4af8dea into main Jan 15, 2022
@angelikatyborska angelikatyborska deleted the deprecate-accumulate branch January 15, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants