Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test script #61

Closed
wants to merge 3 commits into from
Closed

Fix test script #61

wants to merge 3 commits into from

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented Jun 4, 2017

Previously, err_cnt was getting reset for each exercises, so the status code for bin/test-examples only reflected the results of the last (alphabetic) exercise.

@yurrriq yurrriq requested review from canweriotnow and removed request for canweriotnow June 4, 2017 17:37
@stale stale bot added the wontfix label Aug 4, 2017
@stale
Copy link

stale bot commented Aug 4, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@yurrriq yurrriq removed the wontfix label Aug 4, 2017
@yurrriq
Copy link
Member Author

yurrriq commented Aug 4, 2017

TODO: rebase and consider merging

@stale
Copy link

stale bot commented Oct 3, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 3, 2017
@yurrriq
Copy link
Member Author

yurrriq commented Oct 4, 2017

bump

@stale stale bot removed the wontfix label Oct 4, 2017
@benreyn benreyn mentioned this pull request Nov 21, 2017
@benreyn
Copy link
Contributor

benreyn commented Nov 29, 2017

Looks like the Travis Ci builds still link to exercism/xelisp is there a configuration option that needs to changed in travis or do we just need to rebuild this branch?

@benreyn
Copy link
Contributor

benreyn commented Nov 29, 2017

Also, I think that this is the only failure holding this up. @yurrriq can you confirm? Anything I can do to help?

@benreyn
Copy link
Contributor

benreyn commented Dec 18, 2017

@yurrriq, I was taking a second look at this over the weekend, and I believe that rebasing will fix the failing tests (they seem to be passing on master).

@yurrriq
Copy link
Member Author

yurrriq commented Dec 19, 2017

Cool, I can try to take a look soon. Otherwise, feel free to beat me to it.

@benreyn benreyn mentioned this pull request Dec 20, 2017
@yurrriq
Copy link
Member Author

yurrriq commented Jan 8, 2018

Superseded by #76.

@yurrriq yurrriq closed this Jan 8, 2018
@benreyn benreyn deleted the fix-test-script branch April 29, 2018 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants