Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intruducing a version test-case #73

Closed
NobbZ opened this issue Dec 1, 2015 · 9 comments
Closed

Intruducing a version test-case #73

NobbZ opened this issue Dec 1, 2015 · 9 comments
Assignees
Milestone

Comments

@NobbZ
Copy link
Member

NobbZ commented Dec 1, 2015

In an exercise (http://exercism.io/submissions/05fb1f5acd00405aaa36844167c8d603) we assumed that an older test was used, and two of us thought it might be helpfull for thinks like this to have something that tells which version of the testsuite was used.

In the xruby path, there is one test in every suite which tests for the value of a constant of the module/class under test.

An example could be the following

-module(example_tests).

-define(TEST_VERSION, 1).

version_test() -> ?assertMatch(?TEST_VERSION, example:version()).
@kytrinyx
Copy link
Member

kytrinyx commented Dec 1, 2015

We've got these in Go as well. It certainly helps people feel a little bit less miffed when the test suite changes out from under them.

@barberj
Copy link
Contributor

barberj commented Dec 2, 2015

@kytrinyx so is that an approval or does @tmcgilchrist need to weigh in?

@kytrinyx
Copy link
Member

kytrinyx commented Dec 2, 2015

I approve in a generic sense. We need one of the people on the @exercism/erlang team to do the merge, though, since they know the specifics of the track.

@NobbZ
Copy link
Member Author

NobbZ commented Jan 2, 2016

Has this already been disussed in the @exercism/erlang team? This hasn't been touched for a month now.

@kytrinyx
Copy link
Member

kytrinyx commented Jan 2, 2016

If nobody weighs in in the next 24 hours, I'll merge it.

@NobbZ
Copy link
Member Author

NobbZ commented Jan 2, 2016

There's nothing to merge ;) This shall just be a discussion about if we shall introduce some constant value into the testsuites that determine the suites version, as it is done in several other tracks (I know about xruby, you already mentioned xgo)

@kytrinyx
Copy link
Member

kytrinyx commented Jan 2, 2016

Oh, right :)

@NobbZ
Copy link
Member Author

NobbZ commented Jan 22, 2016

Since I was promoted to a maintainer, I will take this one and will start to update the tests accordingly during the next two weeks while taking on #82 at the same time.

@NobbZ NobbZ self-assigned this Jan 22, 2016
@tmcgilchrist
Copy link
Contributor

Late to the party on this but this sounds like a good idea.

@NobbZ NobbZ added this to the 2016 Overhaul milestone Sep 10, 2016
@NobbZ NobbZ mentioned this issue Feb 2, 2017
@NobbZ NobbZ closed this as completed in #135 Feb 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants