Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move exercises to subdirectory #82

Closed
kytrinyx opened this issue Jan 21, 2016 · 5 comments
Closed

Move exercises to subdirectory #82

kytrinyx opened this issue Jan 21, 2016 · 5 comments
Assignees

Comments

@kytrinyx
Copy link
Member

The problems api (x-api) now supports having exercises collected in a subdirectory
named exercises.

That is to say that instead of having a mix of bin, docs, and individual exercises,
we can have bin, docs, and exercises in the root of the repository, and all
the exercises collected in a subdirectory.

In other words, instead of this:

x{TRACK_ID}/
├── LICENSE
├── README.md
├── bin
│   └── fetch-configlet
├── bowling
│   ├── bowling_test.ext
│   └── example.ext
├── clock
│   ├── clock_test.ext
│   └── example.ext
├── config.json
└── docs
│   ├── ABOUT.md
│   └── img
... etc

we can have something like this:

x{TRACK_ID}/
├── LICENSE
├── README.md
├── bin
│   └── fetch-configlet
├── config.json
├── docs
│   ├── ABOUT.md
│   └── img
├── exercises
│   ├── bowling
│   │   ├── bowling_test.ext
│   │   └── example.ext
│   └── clock
│       ├── clock_test.ext
│       └── example.ext
... etc

This has already been deployed to production, so it's safe to make this change whenever you have time.

@NobbZ NobbZ self-assigned this Jan 22, 2016
@NobbZ
Copy link
Member

NobbZ commented Jan 22, 2016

I want to take this one and spread the work over the next two weeks while updating the tests in accordance to #73.

So I have a question about how your system deals with a partial move.
Before merging the update, need all exercises to be moved into the subdirectory, or would everything work when there is only a single one moved and all others are still in a toplevel directory?

@kytrinyx
Copy link
Member Author

Partial/piecemeal move is perfectly acceptable. Right now it checks the new location first for a given exercise, then checks the old location as a fallback.

@tmcgilchrist
Copy link
Contributor

Thanks for doing the move work @NobbZ

@NobbZ
Copy link
Member

NobbZ commented Jan 27, 2016

So I'll move scrabble score and update this PR in the next 12 hours.

@tmcgilchrist
Copy link
Contributor

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants