Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add track icon into img folder #103

Merged
merged 3 commits into from
Jul 4, 2016
Merged

Conversation

PurityControl
Copy link
Contributor

Pull request to resolve issue #101

@NobbZ
Copy link
Member

NobbZ commented Jun 28, 2016

Thank you!
But as far as I understand the explanation in #101 and exercism/exercism#2925, the icon needs to be named icon.{png,svg}, also 693x693 pixels seems quite large to me, and I like to keep that resolution only if it is really necessary.

@kytrinyx: Will a nearly full screen image (it is fullscreen on my phone!) be really necessary on any page, or is a downscale to a more common icon resolution possible? I'm thinking about 128x128 pixels at most, always having my mobile data plan in mind.

@PurityControl
Copy link
Contributor Author

Sorry, more haste less speed. The file is named correctly now. Let me know when you settle on a resolution and I can make the necessary changes.

@kytrinyx
Copy link
Member

I don't think we'll ever need a huge image. I think 300x300 should be more than enough. It would be great to get SVGs for our data plans!

@PurityControl
Copy link
Contributor Author

I have changed the png resolution to 300x300 and added an additional icon file in svg format.

@NobbZ
Copy link
Member

NobbZ commented Jul 4, 2016

Sorry @PurityControl, some reallife happened, hope beeing back again…

Thank you!

@NobbZ NobbZ merged commit 672d990 into exercism:master Jul 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants