-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meetup: add tests that cover the fifth-Xday-of-the-month case? #2142
Comments
That sounds like a good extension. |
I've added individual issues for each language that has a meetup problem. |
You can't regularly schedule a meetup on the fifth week of every month because February usually doesn't have a fifth week at all (and no month ever has a full fifth week). It's nonsense to even support "fifth" as an input in the first place. I think that first-fourth, last, teenth are the only scheduling inputs that should be supported. |
Excellent point! I wish I had thought of this before I opened all the issues :) |
Some solutions to 'meetup' pass the tests, but they don't necessarily handle the date-out-of-bounds situation (eg asking for the fifth Monday of a month that doesn't have five Mondays) -- instead they return a date in the following month.
Would it be possible to add a test that would assert that a date not be returned in these situations (and, say, an exception raised)? And maybe a test asserting that the right date is returned for a month that does have five Mondays?
Thanks!
The text was updated successfully, but these errors were encountered: