Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meetup: add tests that cover the fifth-Xday-of-the-month case? #2142

Closed
witte-de-with opened this issue Dec 27, 2014 · 4 comments
Closed

Meetup: add tests that cover the fifth-Xday-of-the-month case? #2142

witte-de-with opened this issue Dec 27, 2014 · 4 comments

Comments

@witte-de-with
Copy link

Some solutions to 'meetup' pass the tests, but they don't necessarily handle the date-out-of-bounds situation (eg asking for the fifth Monday of a month that doesn't have five Mondays) -- instead they return a date in the following month.

Would it be possible to add a test that would assert that a date not be returned in these situations (and, say, an exception raised)? And maybe a test asserting that the right date is returned for a month that does have five Mondays?

Thanks!

@kytrinyx
Copy link
Member

That sounds like a good extension.

@kytrinyx
Copy link
Member

I've added individual issues for each language that has a meetup problem.

@etrepum
Copy link

etrepum commented Mar 22, 2015

You can't regularly schedule a meetup on the fifth week of every month because February usually doesn't have a fifth week at all (and no month ever has a full fifth week). It's nonsense to even support "fifth" as an input in the first place. I think that first-fourth, last, teenth are the only scheduling inputs that should be supported.

@kytrinyx
Copy link
Member

Excellent point! I wish I had thought of this before I opened all the issues :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants