Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meetup - 5th Monday #32

Closed
kytrinyx opened this issue Mar 22, 2015 · 3 comments
Closed

Meetup - 5th Monday #32

kytrinyx opened this issue Mar 22, 2015 · 3 comments

Comments

@kytrinyx
Copy link
Member

There is an interesting edge case in the meetup problem:
some months have five Mondays.

March of 2015 has five Mondays (the fifth being March 30th), whereas
February of 2015 does not, and so should produce an error.


Thanks, @JKesMc9tqIQe9M for pointing out the edge case.
See exercism.io#2142.

@masters3d
Copy link
Contributor

thanks!

@kytrinyx
Copy link
Member Author

As someone mentioned in the original issue:

You can't regularly schedule a meetup on the fifth week of every month because February usually doesn't have a fifth week at all (and no month ever has a full fifth week). It's nonsense to even support "fifth" as an input in the first place. I think that first-fourth, last, teenth are the only scheduling inputs that should be supported.

So this might be one of those "oops, maybe not" situations.

@masters3d
Copy link
Contributor

Sounds good.

On Sunday, March 22, 2015, Katrina Owen notifications@github.com wrote:

As someone mentioned in the original issue:

You can't regularly schedule a meetup on the fifth week of every month
because February usually doesn't have a fifth week at all (and no month
ever has a full fifth week). It's nonsense to even support "fifth" as an
input in the first place. I think that first-fourth, last, teenth are the
only scheduling inputs that should be supported.

So this might be one of those "oops, maybe not" situations.


Reply to this email directly or view it on GitHub
#32 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants