Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add self-directed help section to CONTRIBUTING.md #3194

Merged
merged 1 commit into from Nov 24, 2016

Conversation

jtigger
Copy link

@jtigger jtigger commented Oct 22, 2016

Implements exercism/discussions#73.

You'll get the most complete feel following this path:

  1. I see a problem...
  2. ... with a specific exercise.

The general intent is for someone with not a lot of experience of behind-the-scenes exercism to quickly find the place and information needed to start contributing... whether it's "just" reporting an issue, submitting a fix/enhancement, or even taking on thinking about more strategic things.

This work will be followed by an effort to split this page and related pages into "modules" of units-of-work that will be referred from this "decision tree." (think: a set of .md files under docs, one per workflow).

Brutally honest feedback, please! :)

@kytrinyx
Copy link
Member

Holy smokes I really like where this is going. The ability to drill down really quickly is powerful.

I'm wishing I had more brutally useful feedback, but I don't. I think you're on to something here.

@@ -131,6 +142,8 @@ Are you a language enthusiast? Help other people fall in love with your languag

### ... Ruby on Rails



Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI we don't actually have any Rails in the project.

@Insti
Copy link

Insti commented Oct 24, 2016

I also like what you're doing here.
(But don't have any specific feedback, just keep doing what you're doing?)


-

### ... getting started with a language
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These ... seem a little odd and distracting to me. But this is just my opinion.

Can we have full sentences like I see a problem getting started with a language?
Something like this:

exercism-contrib

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback, @tejasbubane! The "motivation" behind the ellipsis (...) was to help convey that the reader going through a flow.

If I understand your suggestion, the headers of each landing section is a complete sentence and there are not ellipsis. Yes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the headers of each landing section is a complete sentence and there are not ellipsis. Yes?

Yes. Looks better IMO. Lets see what others have to say.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto. Thanks for the feedback!! If you see think of anything else, big or small, please share!

@jtigger jtigger force-pushed the triage-contribution branch 2 times, most recently from 9ae9d0f to b027e80 Compare November 2, 2016 13:26
@kytrinyx
Copy link
Member

kytrinyx commented Nov 5, 2016

This is a tangent, and you've likely not even considered the aesthetics of it yet, but I've seen people use octicons and/or fontawesome to good effect.

https://octicons.github.com

@jtigger
Copy link
Author

jtigger commented Nov 6, 2016

Note, @kytrinyx, I've rebased over your branch to include references to the Contributor guides you've been working on (#3232) — great stuff!

@jtigger jtigger changed the base branch from master to language-track-docs November 6, 2016 22:56
@jtigger
Copy link
Author

jtigger commented Nov 6, 2016

You're right: I have specifically avoided investing in the graphics part. I'm the LAST guy you want picking graphics. I grabbed some from Google image search that said they were "royalty free".

Re:octicons — very cool!

@jtigger jtigger changed the title [WIP] Contribution Triage Idea Add self-directed help section to CONTRIBUTING.md Nov 16, 2016
@jtigger
Copy link
Author

jtigger commented Nov 16, 2016

At this point, I believe I've reached a milestone with this work and ready to submit for review.

@kytrinyx, I'm specifically deferring doing anything with graphics. I would ❤️ to see someone with graphics design chops give these an Exercism vibe. Far more important seemed to be the contextualizing of someone's intent.

I also followed your advice, @kytrinyx, and created issues for other sections that this guide links to. Those pages point back to their issues, respectively.

Some leaves on this decision tree are stronger than others. I hope by calling this a first iteration of "done", others can start to elaborate/tweak/adjust.

@jtigger
Copy link
Author

jtigger commented Nov 22, 2016

This is such a significant chunk of work (with sub-parts pending), I'd love to either push this through or course-correct as needed.

@kytrinyx?

@kytrinyx
Copy link
Member

@jtigger sorry, I've been traveling non-stop for the past 6 weeks. I'm still traveling, but I'm spending Thanksgiving reviewing PRs and cleaning things up in Exercism, so I'll take a look at this today or tomorrow.

@kytrinyx
Copy link
Member

@jtigger this is an awesome first pass.

I saw an its' vs it's but I'm going to let that get fixed in some subsequent pass. Same with the images.

Thank you so much for taking the time to dig so deeply into this.

@kytrinyx kytrinyx merged commit 743f218 into exercism:master Nov 24, 2016
@ErikSchierboom
Copy link
Member

Wonderful improvement! Great work @jtigger

@jtigger
Copy link
Author

jtigger commented Nov 26, 2016

@kytrinyx I hope I came across as a "squeaky wheel" and not impatient. I'm delighted to get through a first iteration. It's quite imperfect, but I have hope in this approach.

We could really use a designer's eye on this:

  • what are the common goals, workflows and attendant ux?
  • better graphics!!! and
    perhaps ideals on making the visual design easier on the eyes?

@kytrinyx
Copy link
Member

We sure could use a designer's eye!

It feels like there are some different categories of contribution docs:

  1. Exercism, the Product
  2. Exercism, the Curriculum and Language Tracks
  3. GitHub / Workflow / Conventions

And within each of those categories, there are lots of sub-categories.

The thing that is so hard for me to figure out is—where are people starting from? Where are they when they decide to contribute? What do they find first? I have literally not a single clue.

@jtigger jtigger deleted the triage-contribution branch December 2, 2016 14:43
@jtigger
Copy link
Author

jtigger commented Dec 2, 2016

@kytrinyx

The thing that is so hard for me to figure out is—where are people starting from? Where are they when they decide to contribute? What do they find first? I have literally not a single clue.

EXACTLY! That has been one of the most challenging parts in doing this. I spent most of my time on the PR sitting there trying to imagine what are those inbound paths.

It's really easy to want to speak to our audience in terms that we understand... when it's an order-of-magnitude better experience when we shoulder up with them and speak from their perspective.

One thing that started to become clear to me is that this guide is aiming to help the uninitiated.... once someone starts to wrap their arms around the organization and culture of Exercism, such a guided tour becomes less and less useful — there are richer sources of help in terms of the relationships this person has established. So, the good news is that we don't have to account for all paths, just the common ones that new-to-exercism folks might hit.

I've wanted to contribute when:

  • I go through the on boarding process and hit snags.
  • I've seen a bug in the website or in the CLI.
  • I'm reviewing others' submissions and start wishing for features that optimizes my workflow.
  • I'm solving an exercise and find problems with it (usually I'm frustrated with the API spelled out by the tests... but also by the value/path the tests encourage... and then other times the language of the description.md).
  • ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants