-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract "The Contribution Workflow" from CONTRIBUTING.md #3252
Comments
I think we should also add some build-related info - Travis, coveralls, etc. (Refer: #2973) and post-PR fixes - code changes, commit messages, squash, rebase, etc. But I also think this might intimidate first-timers. For others, we should have a documentation to know what standards/practices we are following, what are the cases the build might fail and how to fix that. So either we have separate sections in this doc itself or two new docs - one for newbies and one for experienced people. Something like we have for |
Yeah, that's a good point. Would it help to make the documentation so you only have to read as far as the step that you're on? Kind of like what we've been doing with the launch checklists recently: exercism/prolog#1 |
Hey, I'd love to work on this. Since I am a first time contributor, I think I can get empathize with the target audience of this PR (other people like me who want to contribute). What do I need to do to claim this? (Also, 👋 from @turingschool!) |
@josh-works Awesome! I think you're right that you're in the perfect position to take this one on.
You just did! Thank you ✨ 🌸 ✨ |
(also 👋 to @turingschool! I think about you all often, wondering how you're doing) One thing to be aware of: we're in the process of rebuilding/redesigning exercism.io. It might be worth writing up a generic contributing workflow in https://github.com/exercism/docs and then referring to it here. I don't know if that makes sense—let me know if it seems like a terrible idea. |
^^ sounds like a great idea. I'm back from the long holiday weekend, will be working on this shortly. I'll do a generic one, and link here and get feedback to make it awesome. We're doing great over here at Turing School (well, as far as I can tell! It was perfect for me. I'm about done w/the last mod of the back-end engineering program, have learned a ton, and know enough now to be dangerous and go keep learning in "The Real World". So, wild success for me! |
A most excellent plan :) "enough to be dangerous" is a fun place to be... and even funner if you know that this is where you are in the process. |
I'll add a quick note here - I'd appreciate some feedback on the above PR, at your leisure! |
This would be my first contribution on GitHub but this seems like a good first project to contribute to. I have read the above but am still slightly confused. Is there anyone else I can talk to about this? |
@dmcfaddengalway welcome! 👋 I'm working on this particular issue right now. There's more discussion taking place under the open pull request, which lives here It's still a work in progress (which is why the pull request title has Is, that's the current state of this exact issue. If you're looking for other issues to contribute to, I would start with poking around issues with the "good first patch" label, or take a look at @first-timers-only. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
(part of a larger effort to overhaul documentation around contributing: exercism/discussions#73)
CONTRIBUTING.md#submitting-code-changes outlines the workflow to contributing, from fork to pull request.
It would be incredibly helpful if this outline were extracted and written with first-time contributors in mind:
docs/the-contribution-workflow.md
(please use that name, other work (e.g. Add self-directed help section to CONTRIBUTING.md #3194) is referencing it).The text was updated successfully, but these errors were encountered: