Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Suggest "food for thought" prompts on submissions #3427
Implement suggestion 1 in exercism/discussions#123 (comment).
Initial Prompt Questions
The location of the food for thought may be unnoticed depending on the size of the solution and what is included. At the moment, once the code is read, or once your comment text area is hit, it seems like the need to scroll further down would be unnecessary. The presentation should probably be directly above the "new comment" area, rather than to the left where the space is not guaranteed to be viewed.
In a text only presentation, I would also expect the suggestions to be above my comment, not positioned near the code, above others comments.
As I thought about this, the best location of its placement wasn't obvious to me. Above the comment is a reasonable suggestion. My rationale for placing it below the code, is because considering the prompt is the next logical thing to do after reading the code. Reading the prompt is what might inspire you to make a comment, where you otherwise might have nothing to say. With nothing to say, you're not likely to scroll past any existing comments to find the comment box where the prompt is located. When you read the code and do have thoughts to comment on, then when you go to the comment box, the prompt isn't useful—you already have something to say.