Add random sentence starter placeholders for comments #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps make it clear where to put new requires, and distributes new requires in such a way that future conflicts are less likely. All the tests pass still... Any load-time dependency order requirements should theoretically blow up immediately during the require. That wouldn't hold true if some class were using metaprogramming to search for existing constants to create a list of things matching a pattern or something, but are we doing that? @kytrinyx, is there any reason you can think of that reordering here may cause problems?
If there were issues, they'd show up when running the tests, so I think we're fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the experiment in exercism/discussions#123.
@kytrinyx Please note the commit message in 1880d11
This feature has a similar theme to Prompts. I think they could work alright together, but I'd be interested to get feedback on how that works in practice.