Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coveralls - the newbies guide. #2973

Closed
ghost opened this issue Jul 13, 2016 · 11 comments
Closed

Coveralls - the newbies guide. #2973

ghost opened this issue Jul 13, 2016 · 11 comments

Comments

@ghost
Copy link

ghost commented Jul 13, 2016

I'm confused about the following with Coveralls (https://coveralls.io/) which is being used on Exercism.io and would appreciate feedback on the following:

  • what's the project conventions with using Coveralls?
  • how do we pass?
  • how much do we need to write tests?
  • is there some documentation in relation to Coveralls + Exercism which is written for newbies?
@mhelmetag
Copy link

mhelmetag commented Jul 15, 2016

what's the project conventions with using Coveralls?

It's better if coverage goes up rather than down 😆

how do we pass?

You don't really pass or fail. Coveralls just reports whether test coverage went up or down in the PR branch compared to master.

how much do we need to write tests?

If the method is public and has more than a few lines, it's probably worth testing. In theory, I like to make at least 2 - 3 tests per method: a pass, fail, and edge case. In practice, I try to have at least two. It would probably be nice to stay higher than 75% (currently around 80%).

is there some documentation in relation to Coveralls + Exercism which is written for newbies?

Nope! Not yet.

@kytrinyx
Copy link
Member

Yeah, up is better than down, and we don't have an official threshold, we just want it to be reasonable (75% is a good number, but I wouldn't be alarmed if it dropped a bit below it).

I really, really want to overhaul the documentation and will make a note of the coveralls thing.

@ramyaravindranath
Copy link

I am happy to come up with the document about coveralls for newbies.

@machikoyasuda
Copy link

machikoyasuda commented Jul 25, 2016

@jendiamond the results of this PR could be great for the meetup!. plus coveralls is based out of la/venice.

@tejasbubane
Copy link
Member

Related to #3139

There are two parameters:
coverage threshold for failure and coverage decrease threshold for failure.

@stale
Copy link

stale bot commented May 23, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tejasbubane tejasbubane removed the stale label May 23, 2017
@Insti
Copy link

Insti commented May 23, 2017

This issue is tagged good first patch but I was confused reading through the issue trying to work out what needed to be done.

@tejasbubane what is the actionable task here?

@tejasbubane
Copy link
Member

tejasbubane commented May 23, 2017

I think we should have a doc which addresses these:

  • Little bit about coveralls.
  • What is coverage? (maybe pointing to resources instead of explaining)
  • When can we expect the build to fail with coveralls? (the threshold values set)
  • Why the build fails what should we do to make it pass?

Not sure if this should be a separate file or part of some existing doc.

@kytrinyx
Copy link
Member

Not sure if this should be a separate file or part of some existing doc.

It seems like this could be a separate doc, linked to from the CONTRIBUTING guide.

@ilya-khadykin
Copy link

I can try to create this doc if it's still a relevant issue considering that a new redesigned version of exercism.io is being developed at the moment as stated in 'I would like to help; I know / want to get better at Ruby'

@kytrinyx
Copy link
Member

kytrinyx commented Aug 5, 2017

Hm. I actually think that I'd like to hold off on this. I'm not sure we're going to be using coveralls at all.

I'm going to close this and then once the dust settles in the new redesign we can start considering what guides and docs we need to add.

Thanks @m-a-ge!

@kytrinyx kytrinyx closed this as completed Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants