-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coveralls - the newbies guide. #2973
Comments
It's better if coverage goes up rather than down 😆
You don't really pass or fail. Coveralls just reports whether test coverage went up or down in the PR branch compared to master.
If the method is public and has more than a few lines, it's probably worth testing. In theory, I like to make at least 2 - 3 tests per method: a pass, fail, and edge case. In practice, I try to have at least two. It would probably be nice to stay higher than 75% (currently around 80%).
Nope! Not yet. |
Yeah, up is better than down, and we don't have an official threshold, we just want it to be reasonable (75% is a good number, but I wouldn't be alarmed if it dropped a bit below it). I really, really want to overhaul the documentation and will make a note of the coveralls thing. |
I am happy to come up with the document about coveralls for newbies. |
@jendiamond the results of this PR could be great for the meetup!. plus coveralls is based out of la/venice. |
Related to #3139 There are two parameters: |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is tagged @tejasbubane what is the actionable task here? |
I think we should have a doc which addresses these:
Not sure if this should be a separate file or part of some existing doc. |
It seems like this could be a separate doc, linked to from the CONTRIBUTING guide. |
I can try to create this doc if it's still a relevant issue considering that a new redesigned version of exercism.io is being developed at the moment as stated in 'I would like to help; I know / want to get better at Ruby' |
Hm. I actually think that I'd like to hold off on this. I'm not sure we're going to be using coveralls at all. I'm going to close this and then once the dust settles in the new redesign we can start considering what guides and docs we need to add. Thanks @m-a-ge! |
I'm confused about the following with Coveralls (https://coveralls.io/) which is being used on Exercism.io and would appreciate feedback on the following:
The text was updated successfully, but these errors were encountered: