Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding installation and test notes #37

Merged
merged 4 commits into from Aug 12, 2019

Conversation

pclausen
Copy link
Contributor

Adding installation and test notes based on the same file from https://github.com/exercism/cpp.git

@kotp : Please check if the git log is sane - I still feel very uncertain about what I am doing with git

Adding installation and test notes based on the same file from https://github.com/exercism/cpp.git
docs/INSTALLATION.md Show resolved Hide resolved
docs/TESTS.md Outdated Show resolved Hide resolved
@SaschaMann
Copy link
Contributor

I can't seem to split the comments to separate reviews, the requested change only covers the mention of C++, the other change is up to you to decide.

@SaschaMann
Copy link
Contributor

SaschaMann commented Aug 11, 2019

@kotp : Please check if the git log is sane - I still feel very uncertain about what I am doing with git

This is minor, but commit message subject lines should be written in the imperative mood, e.g. Add instead of Adding in this case. It should be able to complete the sentence "If applied, this commit will your subject line here" (see Chris Beams' blog post for a longer explanation).

Imo not worth changing it for this commit now, but something worth keeping in mind for the future.

@kotp
Copy link
Member

kotp commented Aug 11, 2019

As you are learning Git, it might be worth mentioning that you could do git commit --amend to change the git commit message if you want to, and then doing a git push -f <remote> <branch> if your workflow is explicit... or git push -f if it is implicit.

Co-Authored-By: Sascha Mann <git@mail.saschamann.eu>
Adding Windows Subsystem for Linux (WSL) as option for windows 10 users.
Fix page internal links with '-' instead of spaces
@kotp kotp merged commit 29df455 into exercism:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants