Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add canonical data syncer action #7

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Conversation

ErikSchierboom
Copy link
Member

No description provided.

Copy link
Contributor

@SaschaMann SaschaMann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise!

@@ -0,0 +1,52 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa this is completely different to the fetch-script I knew :D

Since this will likely only ever run on ubuntu, you can drop most of it and hardcode the OS, like here: https://github.com/exercism/github-actions/blob/master/configlet-ci/fetch-configlet

You could also drop the token requirement (I've never run into rate limits without token on ubuntu when just doing single calls).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fetch-configlet script was updated a while ago: https://github.com/exercism/configlet/blob/master/scripts/fetch-configlet

The token is not a requirement, it is optional :) But I could indeed drop some of the stuff.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've liberally "borrowed" your code :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liberally borrowed it from code review feedback in actions/virtual-environments :P

@ErikSchierboom ErikSchierboom merged commit f6f5008 into master Oct 9, 2020
@ErikSchierboom ErikSchierboom deleted the canonical-data-syncer branch October 9, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants