Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update two-fer to match canonical data #142

Merged
merged 1 commit into from Jan 22, 2023
Merged

Update two-fer to match canonical data #142

merged 1 commit into from Jan 22, 2023

Conversation

kytrinyx
Copy link
Member

This updates two-fer to match the canonical specs in the problem-specifications repository.

I hesitated about making it Alice instead of Gilberto Barros
https://github.com/exercism/problem-specifications/blob/51fcbc35abc4ac8d0394d3186f10b2fed04ef3ce/exercises/two-fer/canonical-data.json#L18
because there's no reason why it can't be Gilberto, and I like the creativity of it.

I'd be happy to put that back if you prefer it.

This updates two-fer to match the canonical specs in
the problem-specifications repository.
Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I think we can live with that change, it improves maintainability!

@jiegillet jiegillet merged commit d5a4e84 into main Jan 22, 2023
@jiegillet jiegillet deleted the two-fer branch January 22, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants