-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert of revert with downgrade to Go1.19 #102
Conversation
276accf
to
72d5034
Compare
Pull Request Test Coverage Report for Build 4443526841Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was added after the 1.20 upgrade originally, so it was made assuming go's 1.20 test -json
output. Changed it to match pre-1.20 go's test -json
output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading setup-go fixed a CI issue. We probably want to add dependabot to take care of this for us.
See https://forum.exercism.org/t/tests-failing-with-an-error-occurred/4616/10