Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert of revert with downgrade to Go1.19 #102

Merged
merged 4 commits into from
Mar 17, 2023

Conversation

andrerfcsantos
Copy link
Member

@andrerfcsantos andrerfcsantos commented Mar 17, 2023

@andrerfcsantos andrerfcsantos requested a review from a team as a code owner March 17, 2023 01:46
@andrerfcsantos andrerfcsantos marked this pull request as draft March 17, 2023 01:55
@coveralls
Copy link

coveralls commented Mar 17, 2023

Pull Request Test Coverage Report for Build 4443526841

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 84 of 95 (88.42%) changed or added relevant lines in 4 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.3%) to 64.309%

Changes Missing Coverage Covered Lines Changed/Added Lines %
testrunner/extract.go 13 14 92.86%
testrunner/execute.go 49 59 83.05%
Files with Coverage Reduction New Missed Lines %
testrunner/execute.go 1 56.18%
testrunner/extract.go 3 77.5%
Totals Coverage Status
Change from base Build 4442861009: 1.3%
Covered Lines: 400
Relevant Lines: 622

💛 - Coveralls

@andrerfcsantos andrerfcsantos marked this pull request as ready for review March 17, 2023 02:45
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was added after the 1.20 upgrade originally, so it was made assuming go's 1.20 test -json output. Changed it to match pre-1.20 go's test -json output.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading setup-go fixed a CI issue. We probably want to add dependabot to take care of this for us.

@iHiD iHiD merged commit 3926fbd into exercism:main Mar 17, 2023
@andrerfcsantos andrerfcsantos deleted the revert-of-revert-go1.19 branch March 25, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants