Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gigasecond: use times (not dates) for inputs and outputs #63

Closed
kytrinyx opened this issue Jan 24, 2015 · 2 comments
Closed

gigasecond: use times (not dates) for inputs and outputs #63

kytrinyx opened this issue Jan 24, 2015 · 2 comments

Comments

@kytrinyx
Copy link
Member

A duration of a gigasecond should be measured in seconds, not
days.

The gigasecond problem has been implemented in a number of languages,
and this issue has been generated for each of these language tracks.
This may already be fixed in this track, if so, please make a note of it
and close the issue.

There has been some discussion about whether or not gigaseconds should
take daylight savings time into account, and the conclusion was "no", since
not all locations observe daylight savings time.

@etrepum
Copy link
Contributor

etrepum commented Feb 1, 2015

With regard to daylight savings, if you're using a standard library it will almost certainly take daylight savings into account for you. This could make it hard to write the tests properly unless you normalize the test datetimes to UTC or build them from epoch seconds (which would reveal a very obvious way to solve the problem).

@kytrinyx
Copy link
Member Author

kytrinyx commented Feb 1, 2015

In that case I suggest that let the daylight savings stuff as is.

etrepum added a commit that referenced this issue Feb 2, 2015
gigasecond: use times (not dates) for inputs and outputs (#63)
@etrepum etrepum closed this as completed Feb 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants