Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edge case test for defaults in sum-of-multiples #134

Closed
wants to merge 1 commit into from

Conversation

petemcfarlane
Copy link
Contributor

The README.md says

Write a program that can find the sum of the multiples of a given set of numbers. If no set of numbers is given, default to 3 and 5.

I have updated the tests (and example) to add this edge case.

@petertseng
Copy link
Member

Hello, and thanks for helping out! We're in the process of removing those defaults though, sorry! They were too confusing, so they were removed in #101, as part of the efforts of exercism/problem-specifications#198

Once we're done with that, then the README can be edited with exercism/problem-specifications#209.

What I think would be good here would be one of two things:

  1. Check https://github.com/exercism/x-common/blob/master/sum-of-multiples.json to see if there are any cases in there that Haskell is missing. If there are, then it would be great to add them!
  2. Check the issues linked-to from Improve Sum of Multiples exercise problem-specifications#198 to see which tracks haven't yet removed their defaults, and help them out by submitting PRs to no longer use defaults. Then we'll be able to remove the defaults sentence from the README.

@petemcfarlane
Copy link
Contributor Author

Hi @petertseng, sorry I hadn't seen that PR! I'll make a new PR to update the test cases.

@kytrinyx
Copy link
Member

Thanks @petemcfarlane -- and sorry about the confusion. Still trying to figure out how to manage things like this that affect a bunch of different repositories that exist on slightly different time scales.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants