-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config.json: remove problems key #399
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't like to have to maintain the order of the problems in two places. So, `problems` is removed in favor of the new `exercises`. The `exercises` key was added in #288, as part of the work in #274. We have confirmation from exercism/DEPRECATED.x-api#137 that it is safe to **delete** the `problems` key.
We are not the first track to do it: exercism/csharp#130 and exercism/fsharp#224 |
This was referenced Oct 25, 2016
ErikSchierboom
added a commit
to ErikSchierboom/scala
that referenced
this pull request
Oct 25, 2016
The `problems` key has been obsoleted as per [this issue](exercism/DEPRECATED.x-api#137). This has already been succesfully implemented by the [C#](https://github.com/exercism/xcsharp#130), [F#](https://github.com/exercism/xfsharp#224) and [Haskell](exercism/haskell#399) tracks, so API-wise this is a safe action. Removing the `problems` key also makes it very impossible for people to only add a new exercise in the old, obsolete `problems` key.
ryanplusplus
pushed a commit
to exercism/c
that referenced
this pull request
Oct 25, 2016
The `problems` key has been obsoleted as per [this issue](exercism/DEPRECATED.x-api#137). This has already been succesfully implemented by the [C#](https://github.com/exercism/xcsharp#130), [F#](https://github.com/exercism/xfsharp#224) and [Haskell](exercism/haskell#399) tracks, so API-wise this is a safe action. Removing the `problems` key also makes it very impossible for people to only add a new exercise in the old, obsolete `problems` key.
ryanplusplus
pushed a commit
to exercism/lua
that referenced
this pull request
Oct 25, 2016
The `problems` key has been obsoleted as per [this issue](exercism/DEPRECATED.x-api#137). This has already been succesfully implemented by the [C#](exercism/csharp#130), [F#](exercism/fsharp#224) and [Haskell](exercism/haskell#399) tracks, so API-wise this is a safe action. Removing the `problems` key also makes it very impossible for people to only add a new exercise in the old, obsolete `problems` key.
ErikSchierboom
added a commit
to ErikSchierboom/scala
that referenced
this pull request
Oct 25, 2016
The `problems` key has been obsoleted as per [this issue](exercism/DEPRECATED.x-api#137). This has already been succesfully implemented by the [C#](https://github.com/exercism/xcsharp#130), [F#](https://github.com/exercism/xfsharp#224) and [Haskell](exercism/haskell#399) tracks, so API-wise this is a safe action. Removing the `problems` key also makes it very impossible for people to only add a new exercise in the old, obsolete `problems` key.
camilopayan
pushed a commit
to camilopayan/exercism-php
that referenced
this pull request
Oct 12, 2018
The `problems` key has been obsoleted as per [this issue](exercism/DEPRECATED.x-api#137). This has already been succesfully implemented by the [C#](https://github.com/exercism/xcsharp#130), [F#](https://github.com/exercism/xfsharp#224) and [Haskell](exercism/haskell#399) tracks, so API-wise this is a safe action. Removing the `problems` key also makes it very impossible for people to only add a new exercise in the old, obsolete `problems` key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't like to have to maintain the order of the problems in two
places. So,
problems
is removed in favor of the newexercises
.The
exercises
key was added in #288, as part of the work in #274.We have confirmation from exercism/DEPRECATED.x-api#137
that it is safe to delete the
problems
key.