-
-
Notifications
You must be signed in to change notification settings - Fork 672
-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simple-cipher: update tests and add version file #1475
Comments
@FridaTveit Can I give this a try? |
Go for it @RonakLakhotia 🎉 |
@FridaTveit @sjwarner-bp for the case of "Key is made only of lowercase letters", what should be the input string? |
I might be misunderstanding, but I also find that bit of the canonical data confusing. The input object is empty, which is quite different to the rest of them. I'll take a closer look at the exercise when I am able to, and see if I can make sense of it, otherwise we might have to ask someone in the problem specifications repo 🙂 |
sure. No problem 👍 |
@RonakLakhotia I think what you want to test is:
And then check that |
@FridaTveit I think I get your point. Will give it a try now and get back to you if I face issues. Thanks 😄 |
Hi, is this open to be discussed? Or is @RonakLakhotia still working on it?
|
Hi @anurag-rai 🙂 I think it's been long enough that it's safe to assume @RonakLakhotia is not working on it anymore. To answer your questions:
Does that help? Thanks for wanting to contribute! 😄 |
@FridaTveit : anyone is working on this ? |
@hgvanpariya I don't think so unless @anurag-rai is working on it? 🙂 |
please feel free to work on it :) |
Thank you , I'm working on this ... |
@FridaTveit : need your code review comments .... |
@FridaTveit is this issue still valid? |
@RonakLakhotia yes 🙂 |
The simple-cipher tests should be updated to exactly match the canonical data. Also a version file should be added to match the canonical data version.
The text was updated successfully, but these errors were encountered: