Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change TestTrack.getRankedCars stub to take a list of cars, consistent with the unit tests #2337

Merged
merged 2 commits into from Aug 23, 2023
Merged

Change TestTrack.getRankedCars stub to take a list of cars, consistent with the unit tests #2337

merged 2 commits into from Aug 23, 2023

Conversation

IsaacG
Copy link
Member

@IsaacG IsaacG commented Aug 20, 2023

Reviewer Resources:

Track Policies

@sanderploegsma sanderploegsma mentioned this pull request Aug 22, 2023
Closed
@sanderploegsma
Copy link
Contributor

  • Not sure why CI isn't picking this up, but the exemplar implementation in .meta/src/reference/java/TestTrack.java also contains the invalid method signature and should therefore be updated as well
  • The code snippet in the instructions should probably be updated to match the new signature by passing it unsortedCars

iHiD
iHiD approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@iHiD iHiD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blind approving for you :)

@IsaacG
Copy link
Member Author

IsaacG commented Aug 23, 2023

Thanks! I updated additional sites called out by @sanderploegsma

@iHiD iHiD merged commit 1cae702 into exercism:main Aug 23, 2023
3 checks passed
This was referenced Aug 23, 2023
Closed
Closed
@sanderploegsma
Copy link
Contributor

This also fixes #2330 and #2318 by the way

sanderploegsma pushed a commit to sanderploegsma/exercism-track-java that referenced this pull request Aug 23, 2023
@IsaacG @sanderploegsma
Change TestTrack.getRankedCars stub to take a list of cars, consisten…
0ef6e09 
…t with the unit tests (exercism#2337)

* Change TestTrack.getRankedCars stub to take a list of cars, consistent with the unit tests

* Update additional getRankedCars functions
This was referenced Aug 24, 2023
Closed
Closed
@sanderploegsma sanderploegsma mentioned this pull request Aug 24, 2023
Closed
@IsaacG IsaacG deleted the fix_ranked_stub branch September 22, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iHiD iHiD iHiD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IsaacG @sanderploegsma @iHiD