Fix compile error in Remote Control Competition #2338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default implementation of the `TestTrack` class in Remote Control Competition doesn't match the expected signature in the unit tests, causing the compilation to fail until the student updates the dummy method to match the correct signature.
|
And a side note: I don't get why this wasn't caught in CI? AFAIK the CI test job runs the unit tests on the examplar implementations, right? This should also have resulted in a compilation error, so I suspect the CI job is not 100% doing what it's supposed to do... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default implementation of the
TestTrackclass in Remote Control Competition doesn't match the expected signature in the unit tests, causing the compilation to fail until the student updates the dummy method to match the correct signature.It looks like this was introduced in #2283 where the unit tests were updated but the stub implementation wasn't.
Note that this is a duplicate of #2331, #2336 and #2337, but the former updates the assertions in a way that doesn't make a lot of sense, and the latter two update the stub but not the exemplar implementation nor the instructions.
Fixes #2330, #2318
Reviewer Resources:
Track Policies