Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder track #286

Merged
merged 5 commits into from
Feb 20, 2017
Merged

Reorder track #286

merged 5 commits into from
Feb 20, 2017

Conversation

stkent
Copy link
Contributor

@stkent stkent commented Feb 11, 2017 •
edited
Loading

Waiting on exercism/discussions#60 (comment) before I add difficulty scores to the individual exercises.

Should not be merged before #277. #277 is now merged, so the track tests no longer use the problems key.

Should not be merged before #292 is resolved. done!

Relates to #142, #125

@stkent
Remove deprecated problems key
66ae147 
This should have no effect on the track since the problems key is
long-deprecated, see exercism/DEPRECATED.x-api#137 for
confirmation.
@stkent
Reorder exercises array to match initial difficulty rankings
87a6552
@stkent
Copy link
Contributor Author

stkent commented Feb 11, 2017

Per other tracks that have made this change and assigned difficulties (e.g. https://github.com/exercism/xobjective-c/pull/125/files, https://github.com/exercism/xhaskell/pull/402/files, https://github.com/exercism/xfsharp/pull/198/files) I'll be rounding our computed average difficulties to integer values!

@stkent
Copy link
Contributor Author

stkent commented Feb 11, 2017

Once this PR is finalized and merged, I'll create separate issues for updating the difficulty score and track position for clock and perfect-numbers. After that any new exercises should probably propose both those attributes in the initial PR?

@stkent stkent changed the title [Do not merge] Reorder track Reorder track Feb 13, 2017
@stkent
Copy link
Contributor Author

stkent commented Feb 13, 2017

This is now ready for review!

@stkent stkent changed the title Reorder track [Do not merge] Reorder track Feb 13, 2017
@stkent
Copy link
Contributor Author

stkent commented Feb 13, 2017

This is paused again pending resolution of #292 :)

jtigger
jtigger suggested changes Feb 13, 2017
View reviewed changes
Copy link
Contributor

@jtigger jtigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm disproportionately excited about this PR!!!!!

With your adjustment in the spreadsheet, grade-school has actually landed as a 6 (it's a 5 in the PR).

config.json Outdated
"slug": "minesweeper",
"difficulty": 1,
"slug": "etl",
"difficulty": 6,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your place etl!!!! :)

@jtigger
Copy link
Contributor

jtigger commented Feb 13, 2017

Fun stats...

The following exercises held their positions:

  • hello-world
  • triangle
  • accumulate
  • robot-simulator
  • queen-attack

The five exercises dropping in position the most:

  • secret-handshake (-46 positions)
  • matrix (-40 positions)
  • flatten-array (-37 positions)
  • diamond (-36 positions)
  • twelve-days (-33 positions)

The five exercises climbing in position the most:

  • meetup (+42 positions)
  • anagram (+41 positions)
  • etl (+38 positions)
  • crypto-square (+28 positions)
  • simple-cipher (+26 positions)

@jtigger jtigger mentioned this pull request Feb 14, 2017
Closed
@stkent
Copy link
Contributor Author

stkent commented Feb 14, 2017

grade-school is now positioned in the middle of the sixes!

@stkent
Copy link
Contributor Author

stkent commented Feb 14, 2017

@jtigger I'm also v. excited about this step towards making the Java track much more approachable!

@stkent stkent changed the title [Do not merge] Reorder track Reorder track Feb 16, 2017
@stkent
Copy link
Contributor Author

stkent commented Feb 16, 2017

I believe this is now ripe for review again!

@jtigger
Copy link
Contributor

jtigger commented Feb 20, 2017

I meant to signal 4 days ago that my folks were in town and I'd be far less responsive. :-/ So much for advanced warning.

I apologize for any inconvenience I've caused seemingly sitting on PRs, here. Will get to these later today or tomorrow morning, the latest.

@stkent
Copy link
Contributor Author

stkent commented Feb 20, 2017

@jtigger absolutely no worries; this PR in particular has been through the do-not-merge/ready-for-merge cycle several times over!

@jtigger
Copy link
Contributor

jtigger commented Feb 20, 2017

We'll be making little adjustments as we talk through some of our wider-margined scoring. In the meantime, let's merge this in! Woohoo!!

@jtigger jtigger merged commit a6989cc into master Feb 20, 2017
@jtigger jtigger deleted the reorder-track branch February 20, 2017 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtigger jtigger jtigger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stkent @jtigger